Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #3

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Improvements #3

wants to merge 22 commits into from

Conversation

ash-raph
Copy link

In this PR, I have accomplished the following:

  • Split the data access from the script logic
    • This will enhance the readability since the logic will be clear on all sides
    • Easy to handle issues and exceptions
    • Allow multiple developers to work on the project -avoid conflicts-
  • Split the setting in a separate file
    • This will enhance the readability
    • Make the setting more controlled from environment file
  • Add tests
    • Ensure the code is working fine
    • Using mocks and freezegun allowed us to test all methods in the project
  • Enhance dev environment
    • By adding gitignore, pipenv and pre-commit, will enhance the code quality and the code is running in all environments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant