Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed issue #936 #1050

Closed
wants to merge 2 commits into from
Closed

Conversation

lishukie6588
Copy link
Contributor

@lishukie6588 lishukie6588 commented Dec 7, 2023

Added an additional FAQ addressing the hidden limit of 50 shows per request for the API endpoints related to accessing/adding/deleting current user saved shows suffixed by "current_user_saved_shows" in client.py, resulting in an unexplained HTTP error response.

#936

@dieser-niko
Copy link
Member

I'm not sure about this.

This limit is not hidden. It is clearly documented in Spotify's Web API for each parameter and is being used as a default value in the spotipy library.

If a programmer missed these mentions, they're likely to miss the FAQ.

@dieser-niko
Copy link
Member

I just noticed that stephanebruckert has changed the tags on the mentioned issue. I'll keep this open until this is resolved.

@stephanebruckert
Copy link
Member

Ok let's close this. After reviewing, it seems the issue in #936 can be addressed with updates to docstrings, code, or warnings. No need to add it to the FAQ; the issue itself is sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants