New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python-SDK Implementation for Ocean GKE #162

Merged

chandra1-n merged 8 commits into v2 from SPOTAUT-18355-ocean-gke-implementation

Apr 24, 2024

Contributor

ramrutha497 commented Apr 8, 2024 •

edited

Loading

This is the default pull request template. You can customize it by adding a pull_request_template.md at the root of your repo or inside the .github folder.

Jira Ticket

https://spotinst.atlassian.net/browse/SPOTAUT-18355
https://spotinst.atlassian.net/browse/SPOTAUT-18443

Include a link to your Jira Ticket
Example: JIRAISS-1234

Demo

Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route

Checklist:

I have filled relevant self assessment (NodeJS, Frontend, Backend)
I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have validated all the requirements in the Jira task were answered
I have all neccessary approvals for the design/mini design of this task
I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)


          ocean gke implementation

f756c8c

ramrutha497 requested a review from anuragsharma-123

April 8, 2024 11:30


          update model changes

f26da86

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/models/ocean/gcp/__init__.py Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/models/ocean/gcp/__init__.py Outdated Show resolved Hide resolved

chandra1-n requested changes

View reviewed changes

chandra1-n left a comment

please fix the review comments

ramrutha497 added 2 commits

April 23, 2024 19:15


          Merge branch 'v2' into SPOTAUT-18355-ocean-gke-implementation

5c4c045


          Update review comments

a7bdde1

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/clients/ocean/__init__.py Outdated Show resolved Hide resolved

chandra1-n reviewed

View reviewed changes

spotinst_sdk2/models/ocean/gcp/__init__.py Outdated Show resolved Hide resolved

chandra1-n requested changes

View reviewed changes

chandra1-n left a comment

please fix the review comments

ramrutha497 and others added 3 commits

April 23, 2024 23:10


          review fixes

4b0d3d2


          update model file changes

0a196c1


          Update __init__.py

76863e9

chandra1-n previously approved these changes

View reviewed changes


          Documentation / packaging and version updates

anuragsharma-123 dismissed chandra1-n’s stale review via

April 24, 2024 11:17

chandra1-n approved these changes

View reviewed changes

chandra1-n merged commit fb6b2a1 into v2

2 checks passed

chandra1-n deleted the SPOTAUT-18355-ocean-gke-implementation branch

April 24, 2024 11:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet