Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding annotation support for ocean-controller deployment #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding annotation support for ocean-controller deployment #42

wants to merge 3 commits into from

Conversation

himanshu-josh1
Copy link

Adding annotation support for ocean-controller deployment . This will help in reloading secrets and config map in case they are to be changed

loganjohnlong
loganjohnlong reviewed Apr 10, 2023
View reviewed changes
charts/spotinst-kubernetes-cluster-controller/templates/deployment.yaml Outdated
{{- with .Values.deploymentAnnotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganjohnlong loganjohnlong Awaiting requested review from loganjohnlong

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshu-josh1 @loganjohnlong