Merge pull request #177 from spotify/mattbrown/issue-176-2

add java.lang.invoke.VarHandle to ClassLoader.BLACKLIST
spotify · Jul 8, 2021 · 4c0741e · 4c0741e
2 parents c6cb554 + 0317a60
commit 4c0741e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+### 0.2.4
+
+Added `java.lang.invoke.VarHandle` to the list of classes with
+`@HotSpotIntrinsicCandidate` annotated methods which are excluded from analysis.
+Calls to `VarHandle` methods will no longer result in missinglink generating
+false warnings about methods like `getAndSet` not existing.
+
 ### 0.2.3
 
 Upgraded a number of dependencies:
@@ -47,4 +54,3 @@ Internal changes:
 
 ### 0.1.0 (initial release)
 - core project and maven plugin
-
diff --git a/core/src/main/java/com/spotify/missinglink/ClassLoader.java b/core/src/main/java/com/spotify/missinglink/ClassLoader.java
@@ -80,7 +80,7 @@ public final class ClassLoader {
   // and thus define native methods that don't actually exist in the class file
   // This could be removed if we stop loading the full JDK
   private static final Set<String> BLACKLIST =
-      new HashSet<>(Arrays.asList("java/lang/invoke/MethodHandle"));
+      new HashSet<>(Arrays.asList("java/lang/invoke/MethodHandle", "java/lang/invoke/VarHandle"));
 
   private ClassLoader() {
     // prevent instantiation