WIP: introducing interceptors #232
Conversation
gitrema
force-pushed
the
add-interceptors
branch
4 times, most recently
from
9b486ea to
0bad779
Compare
gitrema
force-pushed
the
add-interceptors
branch
from
0bad779 to
e0e043c
Compare
| - (nonnull instancetype)init NS_UNAVAILABLE; | ||
| + (nonnull instancetype)new NS_UNAVAILABLE; |
There was a problem hiding this comment.
nitpick: nonnull can be removed since this is within the macro's scope
| - (SPTDataLoaderInterceptorResult *)decorateRequest:(SPTDataLoaderRequest *)request; | ||
| - (SPTDataLoaderInterceptorResult *)decorateResponse:(SPTDataLoaderResponse *)response; |
There was a problem hiding this comment.
It's been a while since I've written an Objective-C API 😄 but would this be more idiomatic?
| - (SPTDataLoaderInterceptorResult *)decorateRequest:(SPTDataLoaderRequest *)request; | |
| - (SPTDataLoaderInterceptorResult *)decorateResponse:(SPTDataLoaderResponse *)response; | |
| - (nullable SPTDataLoaderRequest *)decoratedRequest:(SPTDataLoaderRequest *)request error:(NSError * _Nullable *)error; | |
| - (nullable SPTDataLoaderResponse *)decoratedResponse:(SPTDataLoaderResponse *)response error:(NSError * _Nullable *)error; |
There was a problem hiding this comment.
maybe but they are easier to be rewritten in Swift like that ;)
| SPTDataLoaderInterceptorChain * chain = | ||
| [[SPTDataLoaderInterceptorChain alloc] initWithInterceptors:self.interceptors]; | ||
| @synchronized(self.requestToInterceptorChain) { | ||
| [self.requestToInterceptorChain setObject:chain forKey:request]; |
There was a problem hiding this comment.
Given that self.interceptors is immutable and the chain does not store information unique to each request, is it necessary to be creating a chain for every request?
It seems like self.interceptors and self.requestToInterceptorChain could be replaced with a single self.interceptorChain property.
There was a problem hiding this comment.
It can as it is right now. I was thinking ahead by adding Cancellation at some point and I thought to cancel the single interceptor that is running for a given request (given multiple ones can be in a different stage of the interceptor chain). On the other hand all the interceptors can be cancelled at the same time regardless if they are in use and demand to the implementation to properly handle it.
Implement the interceptor patterns to allow users of the SPTDataLoader to provide their own set of interceptors.