Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies & stricter clippy #1

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update dependencies & stricter clippy #1

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e30f00b
Set workspace resolver
mladedav Aug 29, 2024
c89469e
Upgrade dependencies
mladedav Aug 29, 2024
c8ee54c
Setup stricter clippy
mladedav Aug 29, 2024
5bdb4ac
Add rust-toolchain.toml file
mladedav Aug 29, 2024
0168005
Fix new clippy lints
mladedav Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spotflow/rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[toolchain]
channel = "1.80.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any advantage of setting the toolchain to a fixed version? We currently always use the current version in CI (i.e. the version installed on the current runner) and AFAIK it works quite well. For example, we don't have to think about updating the toolchain manually. But maybe there's something I'm missing.