Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor: 공고 조회 시 지원 가능 여부 확인 #220

Merged
merged 3 commits into from
Feb 17, 2024
Merged

♻️ refactor: 공고 조회 시 지원 가능 여부 확인 #220

merged 3 commits into from
Feb 17, 2024

Conversation

oxdjww
Copy link
Member

@oxdjww oxdjww commented Feb 17, 2024

☝️Issue Number

🔎 Key Changes

  • 공고 조회 시, authOrganization을 사용하여 처음 제안하는 것인지 확인합니다.

💌 To Reviewers

  • from 함수의 쓰임새가 한 곳이 아니라 프론트에서 쓰임새 파악하고 Response DTO를 더 구현해서 클린하게 하려 했지만.. 데모데이가 얼마 남지 않은 관계로 조금 의미 없는 변수가 사용되었습니다 참고해주세요! (ProposeDetailsGetResponse 31행)
  • 우선 propose를 조회할 때는 기본적으로 제안을 한 상태일테니 false로 넣어두었습니다

@oxdjww oxdjww added the refactor Refactoring code label Feb 17, 2024
@oxdjww oxdjww self-assigned this Feb 17, 2024
@oxdjww oxdjww linked an issue Feb 17, 2024 that may be closed by this pull request
️♻️ refactor: 공고 조회 시 지원 가능 여부 #219
Closed
1 task
@oxdjww oxdjww merged commit 395e59f into develop Feb 17, 2024
1 check passed
@oxdjww oxdjww deleted the refactor/#219 branch February 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oxdjww oxdjww

Labels
refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

️♻️ refactor: 공고 조회 시 지원 가능 여부
1 participant
@oxdjww