-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack: Feature - Added action to ask question using slack blocks #33
base: next
Are you sure you want to change the base?
Conversation
@@ -4596,6 +4596,507 @@ | |||
}, | |||
"versions": "EQ(*)" | |||
}, | |||
{ | |||
"action": "ask question with block", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we have precedent with the send message
action to optionally take a message string or a blocks JSON. Why not apply the same logic to the existing ask question
action instead of implementing a whole new action here?
It seems to me the additional parameters in this action could prove useful in the ask question
action as well, and if it mostly shared an implementation with ask question channel
, could be used to enhance both actions with block capabilities at once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phantom-jacob
Yeah I was also considering this option, as it was initially for quick customer engagement I went with easier for me to implement option at the time, but we definitely could add this capability to the existing action.
"order": 2 | ||
}, | ||
"timeout": { | ||
"description": "Number of seconds after wich question times out. Default: 1800s (30min)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Number of seconds after wich question times out. Default: 1800s (30min)", | |
"description": "Number of seconds after which question times out. Default: 1800s (30min)", |
"order": 4 | ||
}, | ||
"answer_feedback": { | ||
"description": "Custom message to send when users answers the question", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Custom message to send when users answers the question", | |
"description": "Custom message to send when a user answers the question", |
"order": 5 | ||
}, | ||
"show_user_answer": { | ||
"description": "Option to show or not user's answer in feedback message", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Option to show or not user's answer in feedback message", | |
"description": "Whether or not to show user's answer in feedback message", |
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
please document them in the
manual_readme_content.md
.manual_readme_content.md
all methods (eg, OAuth) used to authenticatewith the service that the connector is integrating with.
manual_readme_content.md
.the Vault API.
nosemgrep
?If yes, please provide justification in an additional comment next to the ignored code.
Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
[
{
"type": "context",
"elements": [
{
"type": "plain_text",
"text": "Which do you choose?",
"emoji": true
}
]
},
{
"type": "actions",
"elements": [
{
"type": "button",
"text": {
"type": "plain_text",
"text": "Option 1",
"emoji": true
},
"value": "option1",
"action_id": "option1"
},
{
"type": "button",
"text": {
"type": "plain_text",
"text": "Option 2",
"emoji": true
},
"value": "option2",
"action_id": "option2"
},
{
"type": "button",
"text": {
"type": "plain_text",
"text": "Option 3",
"emoji": true
},
"value": "option3",
"action_id": "option3"
}
]
}
]
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!