Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to exit after retrieving JWTs (closes #121) #132

Closed
wants to merge 5 commits into from

Conversation

keeganwitt
Copy link
Contributor

No description provided.

@kfox1111
Copy link
Contributor

Why two flags? There ever going to be a case where both jwt and x509 are enabled at the same time? If so, it probably should wait for both? If two flags, it may be confusing in that case.

@faisal-memon
Copy link
Collaborator

Im planning to do a small refactor to create a daemon mode flag. when disabled will just download the x509 and/or JWTs and then exit. That should cover this with only a single flag.

@keeganwitt
Copy link
Contributor Author

Why two flags? There ever going to be a case where both jwt and x509 are enabled at the same time? If so, it probably should wait for both? If two flags, it may be confusing in that case.

Yes, I was thinking some use cases might require both. Ideally, yes, it would wait for both. But I wasn't sure how to implement that, particularly since there might be multiple JWTs. If someone can guide me with an idea, I'll give it a shot.

@faisal-memon
Copy link
Collaborator

@keeganwitt Finally got around to creating the PR i mentioned above with a single daemon_mode flag. Please take a look and lmk if its ok to close this PR. #161

@keeganwitt
Copy link
Contributor Author

Conceptually, yea, think that will solve what I was trying to do here.

@keeganwitt keeganwitt closed this May 22, 2024
@keeganwitt keeganwitt deleted the exit_on_jwt_success branch September 19, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants