Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for create egress policy #911

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add validation for create egress policy #911

merged 1 commit into from
Nov 2, 2023

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Nov 1, 2023

Fix #844

Fix #874

  • Fix EgressClusterPolicy 的校验
  • Add rr policy 可用 egress ip 校验

@lou-lan lou-lan requested a review from weizhoublue as a code owner November 1, 2023 12:08
@lou-lan lou-lan added the release/none should not recoded in new release label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #911 (2bebdf2) into main (d2a8873) will increase coverage by 0.10%.
Report is 4 commits behind head on main.
The diff coverage is 57.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   43.98%   44.09%   +0.10%     
==========================================
  Files          20       20              
  Lines        3042     3089      +47     
==========================================
+ Hits         1338     1362      +24     
- Misses       1513     1531      +18     
- Partials      191      196       +5     
Flag Coverage Δ
unittests 44.09% <57.61%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controller/webhook/validate.go 56.10% <57.61%> (-1.37%) ⬇️

@lou-lan lou-lan changed the title Add validation for create egress policy WIP: Add validation for create egress policy Nov 2, 2023
@lou-lan lou-lan changed the title WIP: Add validation for create egress policy Add validation for create egress policy Nov 2, 2023
@lou-lan lou-lan requested review from bzsuni and biqiangwu November 2, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/none should not recoded in new release
Projects
None yet
3 participants