Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default egress gateway problem #1045

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

bzsuni
Copy link
Collaborator

@bzsuni bzsuni commented Dec 11, 2023

Fix the default egress gateway problem
Fix the auto-nightly-ci workflow not being triggered correctly when manually triggered on a non-main branch
Fix the calico_install empty parameters error
Fix #1044

@bzsuni bzsuni added the release/none should not recoded in new release label Dec 11, 2023
@bzsuni bzsuni requested a review from weizhoublue as a code owner December 11, 2023 02:49
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #1045 (dd5e170) into main (ee2aa76) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1045   +/-   ##
=======================================
  Coverage   44.43%   44.43%           
=======================================
  Files          21       21           
  Lines        3261     3261           
=======================================
  Hits         1449     1449           
  Misses       1606     1606           
  Partials      206      206           
Flag Coverage Δ
unittests 44.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bzsuni bzsuni force-pushed the bz/fix/default-gateway branch 7 times, most recently from 321af84 to 72a0497 Compare December 11, 2023 11:22
@bzsuni bzsuni requested a review from lou-lan December 11, 2023 11:28
lou-lan
lou-lan previously approved these changes Dec 11, 2023
@bzsuni bzsuni force-pushed the bz/fix/default-gateway branch 2 times, most recently from e81eb6a to 99c2a07 Compare December 12, 2023 02:18
Makefile.defs Outdated Show resolved Hide resolved
@bzsuni bzsuni force-pushed the bz/fix/default-gateway branch from 99c2a07 to 4ad436f Compare December 12, 2023 02:25
@bzsuni bzsuni force-pushed the bz/fix/default-gateway branch from 4ad436f to dd5e170 Compare December 12, 2023 03:09
@lou-lan lou-lan merged commit 591462a into main Dec 12, 2023
177 checks passed
@lou-lan lou-lan deleted the bz/fix/default-gateway branch December 12, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/none should not recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Night CI 2023-12-10: Failed -- the default gateway already exists
3 participants