-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of PEP 695 functions #13328
Conversation
Hum, there's a consistent CI failure here but I doubt it's related to my change. |
Some possibility: it's because we're running tests in parallel but I don't know why it would consistently fail =/ |
We don't run tests in parallel on Windows or macOS, yet. A |
This is extremely weird! I don't really know why it's like this then :( I'm trying some stuff here and there (I don't have a testing environment on Windows...) |
Ok, so even without the
And it appears that the following doesn't create the environment correctly? with http_server(InventoryHandler, port=project.port):
# clean build
confoverrides = BASE_CONFIG | {'intersphinx_mapping': project.record}
app = SphinxTestApp('dummy', srcdir=tmp_path, confoverrides=confoverrides)
app.build()
app.cleanup() What's funny is that it's something I wrote. I will be offline until Saturday, so if you can investigate this I would be happy :( |
I'm not sure if the following error:
actually happened before or after the failed assertion. Because the |
So now the CI works..? |
The best kind of errors are transient... |
Supersedes #11796.