Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of PEP 695 functions #13328

Merged
merged 8 commits into from
Feb 15, 2025
Merged

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Feb 11, 2025

Supersedes #11796.

@picnixz picnixz mentioned this pull request Feb 11, 2025
@AA-Turner AA-Turner changed the title Fix parsing of PEP-695 functions Fix parsing of PEP 695 functions Feb 11, 2025
@AA-Turner AA-Turner added this to the 8.2.0 milestone Feb 11, 2025
@picnixz
Copy link
Member Author

picnixz commented Feb 11, 2025

Hum, there's a consistent CI failure here but I doubt it's related to my change.

@picnixz
Copy link
Member Author

picnixz commented Feb 11, 2025

Some possibility: it's because we're running tests in parallel but I don't know why it would consistently fail =/

@AA-Turner
Copy link
Member

AA-Turner commented Feb 11, 2025

We don't run tests in parallel on Windows or macOS, yet.

A

@picnixz picnixz marked this pull request as draft February 11, 2025 17:52
@picnixz
Copy link
Member Author

picnixz commented Feb 11, 2025

We don't run tests in parallel on Windows or macOS, yet.

This is extremely weird! I don't really know why it's like this then :( I'm trying some stuff here and there (I don't have a testing environment on Windows...)

@picnixz
Copy link
Member Author

picnixz commented Feb 11, 2025

Ok, so even without the exec(), we still have the Windows failure:

tests/test_extensions/test_ext_intersphinx_cache.py::test_intersphinx_project_fixture PASSED [ 71%]
tests/test_extensions/test_ext_intersphinx_cache.py::test_load_mappings_cache FAILED [ 71%]

And it appears that the following doesn't create the environment correctly?

        with http_server(InventoryHandler, port=project.port):
            # clean build
            confoverrides = BASE_CONFIG | {'intersphinx_mapping': project.record}
            app = SphinxTestApp('dummy', srcdir=tmp_path, confoverrides=confoverrides)
            app.build()
            app.cleanup()

What's funny is that it's something I wrote. I will be offline until Saturday, so if you can investigate this I would be happy :(

@picnixz
Copy link
Member Author

picnixz commented Feb 11, 2025

I'm not sure if the following error:

ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine

actually happened before or after the failed assertion. Because the http_server context manager did not seem to fail (otherwise why would we have entry = project.make_entry()) but maybe http_server suppressed an exception?

@picnixz
Copy link
Member Author

picnixz commented Feb 15, 2025

So now the CI works..?

@picnixz picnixz marked this pull request as ready for review February 15, 2025 22:44
@AA-Turner AA-Turner merged commit 2364f16 into sphinx-doc:master Feb 15, 2025
23 checks passed
@AA-Turner
Copy link
Member

So now the CI works..?

The best kind of errors are transient...

@picnixz picnixz deleted the fix/pep-695-parse branch February 15, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants