Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockable and sizable bitfield widget #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

peclik
Copy link

@peclik peclik commented Nov 18, 2014

  • allows minimize SC's window size
  • dockable
  • dock's title can be hidden with View menu checkbox (more compact layout)

sc-dockable_bitfield

@heldercorreia
Copy link
Collaborator

Hi Richard, thanks for taking the time to contribute to the project! I have just quickly reviewed this pull request, I have a few remarks that I'd like to discuss with you:

  • I'm not crazy about the "Bitfield dock title bar" settings option. I think there are a lot of options in there already, and this one looks very irrelevant, for lack a better word. It's probably a good idea to remove it from the patch. A vertical title, if possible, is probably a better idea.
  • I noticed the width of the bit squares in the widget decreases when the width of the window decreases. Although I see what your goal is, I'm not sure I like the visual aspect or its usability.
  • The side margin of the widget is now very small, it looks bad.
  • When the widget is hidden and there is a partial result popup being shown, if you activate the widget then you'll see an ugly visual artifact caused by the popup being overlapped.

Would love to hear your thoughts. Thanks again!

@peclik
Copy link
Author

peclik commented Nov 19, 2014

Hi Helder, here are my comments:

  • Title bar: the purpose is to make compact calculator window. The large empty title bar only takes precious space for no purpose (usually no one will be moving docks all the time, after he sets the layout he likes). A vertical title looks bad and doesn't work good with other docking widgets.
    I put the option to the View menu, so it's placed along with widget visibility checkbox. So what about placing under the Settings/Display menu or creating new "Expert/Advanced" menu making it .ini file only ("hidden") option? I must say that I will want the same option for the new widget I'm working on.
  • Shrinkable bits: that was the main purpose! ...allowing smaller SC window. If you don't like narrow bits, you can always have nice big squares resizing the main window.
  • Side margin: again - for me the compact window without is priority, but I can understand someone can feel it's unbalanced - no problem adding some margin.
  • Popup artifact - ok, it can be corrected (a problem with the same cause is when you resize main window - tooltip position is not updated when editor moves...).

@heldercorreia
Copy link
Collaborator

bitfield

The (lack of) margin looks really bad on Ubuntu, not too bad on your Windows screenshot. Also, it is possible to resize the dock in the way you can see in the image.

I'm OK with the narrow bits when window size is compact.

If you manage to fix the popup artifact, it would be great to fix the main window resizing on the way. I think hiding the popup prior to all of these actions is enough.

Still not sure about that option to hide the title :) BTW, can you share what other widget you are working on?

@peclik
Copy link
Author

peclik commented Nov 19, 2014

OK, I will add margin.
I don't know how to enforce fixed minimum height while allowing it dock with other widgets - I was trying several ways with no proper result - probable there is a way, but for it's a minor issue.

I want add widget with several live different results - something like in #40, but configurable - user can configure for each line the formula - e.g. hex($f), f+10 etc., where f is a variable containing live result of formula from edit line and it will evaluate and show the result.

And now imagine that I will want visible bitfield widget and this widget bellow - if they will have title bars, there will be too much space wasted. And it will not look good.

newinnovations referenced this pull request in newinnovations/SpeedCrunchSI Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants