-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockable and sizable bitfield widget #45
base: master
Are you sure you want to change the base?
Conversation
peclik
commented
Nov 18, 2014
- allows minimize SC's window size
- dockable
- dock's title can be hidden with View menu checkbox (more compact layout)
Hi Richard, thanks for taking the time to contribute to the project! I have just quickly reviewed this pull request, I have a few remarks that I'd like to discuss with you:
Would love to hear your thoughts. Thanks again! |
Hi Helder, here are my comments:
|
The (lack of) margin looks really bad on Ubuntu, not too bad on your Windows screenshot. Also, it is possible to resize the dock in the way you can see in the image. I'm OK with the narrow bits when window size is compact. If you manage to fix the popup artifact, it would be great to fix the main window resizing on the way. I think hiding the popup prior to all of these actions is enough. Still not sure about that option to hide the title :) BTW, can you share what other widget you are working on? |
OK, I will add margin. I want add widget with several live different results - something like in #40, but configurable - user can configure for each line the formula - e.g. hex($f), f+10 etc., where f is a variable containing live result of formula from edit line and it will evaluate and show the result. And now imagine that I will want visible bitfield widget and this widget bellow - if they will have title bars, there will be too much space wasted. And it will not look good. |
…uest #45) Number_types_refactor_merged