-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WriteController: Remove redundant setting delay reports with single db #831
Conversation
@Yuval-Ariel - Why not avoid logging in the WC to the reporter's logger? |
@udi-speedb , what you're suggesting wouldnt work when a logger is shared between two dbs. the db that initated the request will get a msg but the other one wouldnt. |
Wouldn't the reporter get a log message from its own column_family.cc code while the other(s) would log the WC's message? |
its the same logger. so both dbs will get any msg |
OK, but if there are multiple delay sources (cf-s, WBM) wouldn't you miss the min rate and only see the new rate? |
we would still get the msg from the cf that initiated the delay |
The WC currently reports to the log whenever a new delay request is handled (even if its the same rate).
These msgs are redundant in cases where the WC is only shared with 1 db and hence 1 logger since similar msgs are reported in ColumnFamilyData::RecalculateWriteStallConditions.
Currently it looks like :
This PR removes the msg from the write_controller (the first) when there is only 1 logger to report to.