Macros during parse #2721
Merged
Macros during parse #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stract superclass.
…e all the macros ready.
…still have a period where I can adjust the metadata.
* Added a 'context' argument to the parser so error messages can more meaningful line numbers. * Made Result use a type variable so I don't propagate Any unnecessarily. * Removed replaceMacros() entirely, in favor of doing all macro replacement directly in the parser. * Aligned replaceMacrosTextly() to use the same macro-detection regex * Split nodesFromHtml() into a new nodesFromStream helper that does all the actual work; nodesFromHtml() just initializes the Stream for you, same as the other parsing entry points. * Better ignored biblio links getting seen by the parser, so they won't be seen as macros. * Defined Stream.subStream(), for when you're parsing while you're parsing. * Made char escapes in attributes correctly stay char escapes. * Fixed escaping in attributes so I only escape double-quotes. * Massively improved the macro tests.
…on of the markdown code span to avoid any potential markdown-parser issues.
…n markdown processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles macros entirely within the new html parser, rather than just recognizing and marking them in the parser but still actually doing the substitution via a whole-doc regex.
Also a number of miscellaneous small fixes in newline handling and line counting uncovered while fixing this stuff.