GitHub actions improvements #606
Conversation
|
OK, it seems to be running fine but its failing because of errors in the |
|
the file .github/workflows/spec-parser.yml is about to be deleted. Your changes will soon conflict |
|
@maxhbr do you want me to delete it in this PR? |
|
Opened spdx/spec-parser#90 to fix an unhandled attribut error breaking the validate-pr workflow. (See this run ) |
I think that this was the agreement. But it is sad to loose the ontospy generation and the other stuff. Maybe we need to create a ticket to bring that back. |
|
The workflow has been broken for a while and hasn't run for a while (see this run for example). I'll fix it so that it can start pushing updates again. |
.github/workflows/validate-pr.yml
Outdated
| name: validate PR | ||
|
|
||
| on: | ||
| pull-request | ||
| pull_request: |
There was a problem hiding this comment.
I don't think the final : is actually needed, if there is nothing underneath in inner levels.
There was a problem hiding this comment.
I think this should get merged, as it will fix #607 (comment)
|
@zvr got it. The question is should we keep the ontospy generation jobs? If yes, I can fix the current workflow that is broken. If not, I can simply delete the spec-parser job (keeping only validate-pr). |
|
No, it will run on the spdx-spec repo and publish the results in rdf.spdx.org (or whatever our URI will be). |
I disagree slightly and think that some artifacts which are purely built from the model should be generated in the spdx-3-model. But that is more relevant for the shacl and related stuff. Ontospy is an edge case and maybe soon no longer helpful. |
.github/workflows/spec-parser.yml
Outdated
| with: | ||
| python-version: "3.11" | ||
| python-version: "3.12" | ||
| - name: get spec-parser |
There was a problem hiding this comment.
This section where we run the spec-parser should be deleted - the current output formats don't currently work with the latest version.
@licquia will add this back to the spec-parser repo
.github/workflows/spec-parser.yml
Outdated
| @@ -31,33 +34,21 @@ jobs: | |||
| - name: run spec-parser | |||
|
|
||
| - name: validate that context is valid | ||
| run: | | ||
| python3 -m pip install rdflib | ||
| python3 ./.github/workflows/test_context.py /tmp/spec-parser.out/context.json |
There was a problem hiding this comment.
I guess we have to remove this as well
|
|
||
| - uses: actions/upload-artifact@v3 |
| @@ -68,28 +59,28 @@ jobs: | |||
| - name: generate docs with Ontospy | |||
| run : | | |||
| cd Ontospy | |||
| mkdir -p /tmp/auto-generated | |||
There was a problem hiding this comment.
I think we should keep this for now until we get the spdx-spec repo up and running
@goneall : we can't keep it, when we drop the generation. To keep that we would need to pin the spec-parser in the old action to an old version. |
|
I think that this PR should for now drop |
Agree - @puerco - if you could make that change, I can do a quick final review and merge |
This commit updates the actions used to the latest version and pins them using their hashes. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
As discussed in spdx#606 this commit deletes the spec parser workflow. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit updates and pins the actions in the spec-parser workflow Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit simplifies the artifact upload to do it in a single step Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit drops the hardcoded temp path and uses the runner-specific temporary directory. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit normalizes the license boiler plates in the actions code Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit adds the dependabot configuration to keep the actions up to date. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit fixes a bug where the parser repo was clones into the wrong directory Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit fixes the spec-parser workflow to invoke the parser without deprecated flags. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
As discussed in spdx#606 this commit deletes the spec parser workflow. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
|
OK, sounds good 👍 I've deleted the spec-parser workflow in a new commit. This should let us rescue the fixed version if we need it. |
|
I think we should delete |
lets ignore that file for now and just get it merged. I think now everything is green -> merge |
This PR is a follow-up to #604 to update the workflows improving the way actions are setup in the repo, the summary of the changes is the following:
Simplifies the artifact upload in spec-parser to upload everything in one go/tmppath to use the runner-specific temp directoryBump python version in spec-parser to 3.12 to unify it with the version used in valida-prFixes a bug in the directory where the spec parser was being clonedFixes the invocation of the parser inspec-parserUpdate: This PR now deletes the entire
spec-parserworkflow as per the discussion below./cc @zvr @goneall
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]