Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy PackageVerificationCode as an integrity method #599

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

goneall
Copy link
Member

@goneall goneall commented Jan 12, 2024

This pull request adds a legacy package verification code.

Based on the PackageVerificationCode as part of the security profile team call on 12 Jan 2023, we agreed that the model itself support package verification as is as long as we have additional documentation. We decided to postpone the decision on how to handle the legacy package verification codes until after RC2.

This PR is a placeholder for possible inclusion if we decide to add the legacy support.

@goneall goneall added the Profile:Software Software Profile and related matters label Jan 12, 2024
@goneall goneall added this to the 3.0 milestone Jan 12, 2024
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together, would like to include it.

@nishakm
Copy link
Collaborator

nishakm commented Jan 16, 2024

Pending decision after RC2 is released. Per discussion in the SPDX tech meeting dated 2024-01-16, there are use cases where inclusion is required.

@goneall
Copy link
Member Author

goneall commented Jan 17, 2024

@nishakm @kestewart @jeff-schutt - Could you connect on whether this needs to be included for RC2? I'll go along with any decision the 3 of you agree on.

Note that if we do want to include it, we need to decide if this is an enumeration in the hash algorithms + some way of adding excluded files OR if we go with this PR. I do have an opinion on which way we go and I believe @zvr and @maxhbr also have opinions.

@kestewart
Copy link
Contributor

I met with @jeff-schutt after the meeting, and discussed the use cases. He was ok with this going in. @nishakm do you have any reservations other than the missing work for exclusion case?

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nishakm
Copy link
Collaborator

nishakm commented Feb 2, 2024

I met with @jeff-schutt after the meeting, and discussed the use cases. He was ok with this going in. @nishakm do you have any reservations other than the missing work for exclusion case?

No reservations. LGTM.

@kestewart kestewart merged commit b056f72 into main Feb 13, 2024
1 check passed
@xnox
Copy link

xnox commented Mar 5, 2024

Is this required to produce if backwards compatibility is not needed?

@goneall
Copy link
Member Author

goneall commented Mar 5, 2024

Is this required to produce if backwards compatibility is not needed?

No - there are other verification methods which can/should be used such as using the gitoid property on artifacts.

@goneall goneall deleted the pkgvercode3 branch March 5, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profile:Software Software Profile and related matters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants