Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for withoutScopedBindings to ScopeBindings attribute. #139

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Add support for withoutScopedBindings to ScopeBindings attribute. #139

merged 2 commits into from
Mar 24, 2024

Conversation

mikerockett
Copy link
Contributor

@mikerockett mikerockett commented Mar 23, 2024 •
edited
Loading

This is a continuation of #134, with two adjustments:

  1. Given the recent drop of support for Laravel 8 and 9 (521ba0e), there is no need to check whether or not withoutScopedBindings is an existing method.
  2. Tests cater for method-level opt-ins (where the controller defaults to opt-out).

README.md is also updated with changes in behaviour.

@freekmurze freekmurze merged commit bf57239 into spatie:main Mar 24, 2024
17 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikerockett @freekmurze