Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22 removing source dependency #23

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented Sep 17, 2018

I think we don't need any scalaz dependency to compile project ATM.
I removed source dependency to let the project build.
Closes #22.

@GrafBlutwurst
Copy link
Collaborator

👍 solved the issue of the missing snapshot dependency for me

@vil1
Copy link
Member

vil1 commented Sep 19, 2018

LGTM.
We don't use any of scalaz yet, but we'll soon need to add the dependency back later (but as a binary one)
I won't close #23 though, since I'd like the source dependency toward the scalaz-sbt plugin to be changed to binary as well (which is blocked until scalaz/scalaz-sbt#20 is fixed)

@vil1 vil1 merged commit 2202c11 into spartanz:prototyping Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants