Skip to content

Commit

Permalink
test: drop unnecessary assertion on rubyzip read encoding
Browse files Browse the repository at this point in the history
  • Loading branch information
flavorjones committed Jan 6, 2025
1 parent d1f8410 commit 8f64600
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions test/xml/test_document_encoding.rb
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,12 @@ class TestDocumentEncoding < Nokogiri::TestCase

# no final newline on jruby. descriptive, not prescriptive.
expected_length = Nokogiri.jruby? ? xml.bytesize - 1 : xml.bytesize

assert_equal(Encoding::UTF_8, output.encoding)
assert_equal(expected_length, output.bytesize)

# Note: I dropped the assertion on the encoding of the string return from io.read
# because this behavior has changed back and forth in rubyzip versions 2.4.1 and
# 3.0.0.dev, and it's not relevant to the original bug report which was about an
# exception during writing.
end
end
end
Expand Down

0 comments on commit 8f64600

Please sign in to comment.