Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/comment html issue #214

Closed
wants to merge 8 commits into from
Closed

Fix/comment html issue #214

wants to merge 8 commits into from

Conversation

sparcscasio
Copy link
Contributor

Overview

#95 해결

Changes

HTML 랜더링 되는 텍스트와 Text로 제공되는 텍스트 사이의 폰트 차이 문제 해결

Implementaion Method

After Changes

Related Issues

스크린샷 2024-08-17 오후 9 08 39

Rollback Scenario

TODO

thomaskim1130 and others added 8 commits August 12, 2024 06:44
postWritePage의 나가기 dialog에 '임시 저장하기' 버튼 추가
PostWritePage의 ExitConfirmDialog의 onTap 메소드를 추가함(onTapSave/onTapConfirm).
이후 사용 파일 내부에서 임시 저장 코드를 구현하도록 함.
onTapSave(임시저장) 이후, onTapConfirm(나가기)를 자동으로 호출하도록 함.
누락된 post_write_page.dart의 내용을 커밋함.
@sparcscasio sparcscasio requested review from thomaskim1130 and sangohkim and removed request for thomaskim1130 August 17, 2024 12:25
@sparcscasio sparcscasio self-assigned this Aug 20, 2024
@sparcscasio sparcscasio added the bug Something isn't working label Aug 20, 2024
@sparcscasio sparcscasio added this to the v1.2.0 milestone Aug 20, 2024
Copy link
Contributor

@thomaskim1130 thomaskim1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 8번)
현재 github에서 branch를 생성할 때 기존 작업하던 branch에서 commit들을 그대로 불러오신 것 같은데, dev 기반으로 pull을 해야 새로 작업한 commit만 볼 수 있습니다.

@sparcscasio sparcscasio deleted the fix/comment-HTML-issue branch August 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants