[Feature] caching for post write page #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postWritePage의 나가기 dialog에 '임시 저장하기' 버튼 추가
PostWritePage의 ExitConfirmDialog의 onTap 메소드를 추가함(onTapSave/onTapConfirm). 이후 사용 파일 내부에서 임시 저장 코드를 구현하도록 함.
onTapSave(임시저장) 이후, onTapConfirm(나가기)를 자동으로 호출하도록 함.
누락된 post_write_page.dart의 내용을 커밋함.
thomaskim1130
requested changes
Aug 20, 2024
lib/pages/post_write_page.dart
Outdated
| : '/cache/${userID}/'; | ||
|
|
||
| await cacheApiData(key, data); | ||
| print(key); |
There was a problem hiding this comment.
print() 대신 debugPrint()를 사용하는 것이 OS의 compatibility를 높이고 일관성 있다고 합니다
(참고 : https://stackoverflow.com/questions/66841141/flutter-when-to-use-print-and-debugprint)
lib/pages/post_write_page.dart
Outdated
| : 'REGULAR') | ||
| : 'REGULAR', | ||
| }; | ||
| data['parent_topic'] = |
There was a problem hiding this comment.
해당 key들을 data를 정의할 때 사용하지 않은 이유가 있나요? (var data로 지정한 이유)
일반적으로 flutter에서는 Stateful한 상황이 아니면 const 혹은 final을 사용하는 것이 immutability 때문에 선호된다고 합니다
lib/pages/post_write_page.dart
Outdated
| String key = (_isEditingPost) | ||
| ? '/cache/${widget.previousArticle!.id}/' | ||
| : '/cache/${userID}/'; | ||
| dynamic cachedData = await fetchCachedApiData(key); |
There was a problem hiding this comment.
여기서도 마찬가지로 변수형을 dynamic 보다는 dictionary 형태이기 때문에 List<Map<String, dynamic>>로 지정하는 것이 더 일반적입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
캐싱 기능 추가
Changes
ExitConfirmDialog에서 save 선택시 입력한 내용이 캐싱됨
Implementaion Method
After Changes
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-15.at.20.15.24.mp4
Related Issues
Rollback Scenario
TODO