add typehints for directory_layout / Spec.prefix #48652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
core
alalazo
previously approved these changes
Feb 24, 2025
haampie
force-pushed
the
hs/fix/spec-prefix-type
branch
from
da1fed1 to
f25bda5
Compare
alalazo
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec.prefixreturnsspack.util.prefix.Prefixor raises, but static analysis says it can beNonewhich is rather annoying.mypy struggles with getters/setters, so replace the setter with an ordinary function
Spec.set_prefix(...), which is also easier to find as a symbol.In the near (?) future we can consider dropping automatic
Spec.prefixsince it couples Spec to a specific store. But it's unlikely to be removed, just it would throw if Spec.set_prefix(...) wasn't called.