Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluidnumerics-self: new package #48636

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Conversation

fluidnumerics-joe
Copy link
Contributor

This PR adds a new package : FluidNumerics/SELF (the Spectral Element Library in Fortran)

Copy link

spackbot-app bot commented Jan 18, 2025

@fluidnumerics_joe @garrettbyrd can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • self

@alalazo alalazo self-assigned this Jan 20, 2025
@alecbcs alecbcs changed the title Add new package : Spectral Element Library in Fortan self: new package Jan 27, 2025
@fluidnumerics-joe fluidnumerics-joe changed the title self: new package fluidnumerics-self: new package Jan 28, 2025
alalazo
alalazo previously approved these changes Feb 6, 2025
Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a question

alalazo
alalazo previously approved these changes Feb 18, 2025
@alalazo
Copy link
Member

alalazo commented Feb 18, 2025

@spackbot fix style

Copy link

spackbot-app bot commented Feb 18, 2025

Let me see if I can fix that for you!

Copy link

spackbot-app bot commented Feb 18, 2025

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: import, isort, black, flake8, mypy
==> Modified files
  var/spack/repos/builtin/packages/fluidnumerics-self/package.py
==> Running import checks
import check requires Python 3.9 or later
  import checks were clean
==> Running isort checks
  isort checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/fluidnumerics-self/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> Running mypy checks
lib/spack/spack/version/version_types.py:134: error: Incompatible types in assignment (expression has type "Tuple[Any, ...]", variable has type "Tuple[str]")  [assignment]
lib/spack/spack/variant.py:130: error: Unsupported right operand type for in ("Union[Collection[Any], Callable[..., Any]]")  [operator]
lib/spack/spack/build_environment.py:171: error: Overloaded function signatures 1 and 2 overlap with incompatible return types  [misc]
lib/spack/spack/build_environment.py:171: error: Overloaded function signatures 1 and 3 overlap with incompatible return types  [misc]
Found 4 errors in 3 files (checked 636 source files)
  mypy found errors
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@alalazo alalazo enabled auto-merge (squash) February 18, 2025 15:05
@alalazo alalazo merged commit 3fbdfc4 into spack:develop Feb 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants