Skip to content

Commit

Permalink
is_approved_or_changes_requested_by_me() only trigger if logged on us…
Browse files Browse the repository at this point in the history
…ers acted
  • Loading branch information
bernhardkaindl committed Nov 1, 2024
1 parent 78e262f commit e04519b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cli/check.py
Original file line number Diff line number Diff line change
Expand Up @@ -1883,7 +1883,7 @@ def get_reviewers(pr: Dict[str, Any], state: str) -> List[str]:
"""Get the list of approvers of the PR with the given state."""

approvers = []
for review in pr.get("reviews", []):
for review in pr.get("latestReviews", []):
if review["state"] == state:
approvers.append(review["author"]["login"])

Expand Down Expand Up @@ -1927,7 +1927,7 @@ def is_approved_or_changes_requested_by_me(args: argparse.Namespace, pr: Pr) ->

approvers, requesters = print_reviewers(pr)
users = set(args.github_users)
return bool(set(approvers) or users & set(requesters))
return bool(users & set(approvers) or users & set(requesters))


def pull_request_is_ready_for_review(args: argparse.Namespace, pr: Pr) -> bool:
Expand Down

0 comments on commit e04519b

Please sign in to comment.