Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FGS J-FRAME aperture following Oct 2024 FGS1-to-JFrame k-constants update #354

Merged
merged 26 commits into from
Oct 21, 2024
Merged

Update FGS J-FRAME aperture following Oct 2024 FGS1-to-JFrame k-constants update #354

merged 26 commits into from
Oct 21, 2024

Conversation

tonysohn
Copy link
Collaborator

Changing SIAF parameters values for FGS SIAF aperture J-FRAME.
Old and new parameters are:

OLD: (V3IdlYAngle, V2Ref, V3Ref) = (0.041688872 deg, 180.255 arcsec, 175.783 arcsec)
NEW (V3IdlYAngle, V2Ref, V3Ref) = (0.051342419 deg, 196.300 arcsec, 181.806 arcsec)

Note: This aperture is only used by VSS and PPS, and does not affect pointing or pipeline products.

zacharyburnett and others added 24 commits March 14, 2024 14:11
@zacharyburnett
require Python 3.10
ef38195
@zacharyburnett
Update pyproject.toml
9b02633
@zacharyburnett
update references to Python 3.9
29b9f62
@zacharyburnett
update actions version
9e90855
@mperrin
extend plot_main_apertures to also plot HST or Roman apertures
a767382
@jhunkeler
Move numpydoc to [docs] installation target
7526e7b 
* numpydoc and its dependencies should not be required at runtime
@mfixstsci
Merge pull request spacetelescope#349 from mfixstsci/release-0.23.0
56fe105 
Update pysiaf with PRDOPSSOC-067
@mfixstsci
Merge branch 'main' into update/actions
294e856
@mfixstsci
Merge pull request spacetelescope#332 from zacharyburnett/update/actions
57eccb4 
update actions version
@mfixstsci
Merge branch 'main' into scsb145
8460c6c
@mfixstsci
Merge branch 'main' into optional-dependencies-docs-numpydoc
e38ce6c
@mfixstsci
Merge pull request spacetelescope#347 from jhunkeler/optional-depende…
d846c13 
…ncies-docs-numpydoc

Move numpydoc to [docs] installation target
@mfixstsci
Removing 3.12 support
4e8d5fc
@mfixstsci
Merge pull request spacetelescope#337 from zacharyburnett/scsb145
545adb2 
[SCSB-145] require Python 3.10
@mfixstsci
Remove publish to pypi add build ci
de0dee1
@mfixstsci
Merge pull request spacetelescope#350 from mfixstsci/remove-publish-t…
77272ff 
…o-pypi

Remove Publish to pypi
@mperrin
trivial syntax fix to avoid SyntaxWarning
f774d74
@Witchblade101
Merge branch 'main' into escape_sequence_fix
f0173b4
@mfixstsci
Merge pull request spacetelescope#351 from mperrin/escape_sequence_fix
c835ef2 
trivial syntax fix to avoid SyntaxWarning
@mfixstsci
Adding python 3.12 to build matrix
4fa46b3
@mfixstsci
Add pip install setuptools
0edaef5
@mfixstsci
Merge pull request spacetelescope#352 from mfixstsci/add-python-3.12-…
4d55254 
…build

Add Python 3.12 Build
@Witchblade101
Merge pull request spacetelescope#342 from mperrin/plot_main_aperture…
bce46e3 
…s_multimission

extend plot_main_apertures to also plot HST or Roman apertures
Merge remote-tracking branch 'upstream/siaf-updates'
39813ee
@Witchblade101
Copy link
Collaborator

@tonysohn I probably have a case of the Mondays, but these look like they were all older changes. I was expecting to see numbers changed in fgs_siaf_alignment.txt, which isn't one of the files changed in this PR.
@mfix Is this just pulling changes from main into siaf_updates?

@tonysohn
Copy link
Collaborator Author

@tonysohn I probably have a case of the Mondays, but these look like they were all older changes. I was expecting to see numbers changed in fgs_siaf_alignment.txt, which isn't one of the files changed in this PR. @mfix Is this just pulling changes from main into siaf_updates?

I'll check – I may have done something wrong.

Witchblade101
Witchblade101 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@Witchblade101 Witchblade101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merges changes in main to siaf_updates and updates FGS J-FRAME to the values in the SIAF JIRA issue.

@Witchblade101 Witchblade101 merged commit b386490 into spacetelescope:siaf-updates Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Witchblade101 Witchblade101 Witchblade101 approved these changes

Assignees

@Witchblade101 Witchblade101

Labels
source-data-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tonysohn @Witchblade101 @zacharyburnett @mperrin @jhunkeler @mfixstsci