Backport PR #2736 on branch v4.1.x (adjusting links to enable pixel, wavelength linking in specviz2d) #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elength linking in specviz2d
meeseeksmachine
requested review from
pllim,
kecnry,
bmorris3 and
haticekaratay
as code owners
pllim
reviewed
Feb 12, 2025
| @@ -759,8 +759,22 @@ def _link_new_data(self, reference_data=None, data_to_be_linked=None): | |||
| linked_data.ndim < 3 and # Cube linking requires special logic. See below | |||
| ref_data.ndim < 3) | |||
| ): | |||
| links = [LinkSame(linked_data.components[0], ref_data.components[0]), | |||
| LinkSame(linked_data.components[1], ref_data.components[1])] | |||
| if self.config == 'specviz2d': | |||
There was a problem hiding this comment.
Hmm does this render #3434 unnecessary? Did you see if the modeling bug went away only with this patch?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.1.x #3436 +/- ##
=======================================
Coverage 88.08% 88.08%
=======================================
Files 127 127
Lines 19601 19608 +7
=======================================
+ Hits 17265 17272 +7
Misses 2336 2336 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #2736: adjusting links to enable pixel, wavelength linking in specviz2d