Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix ellipse translation in app.get_subsets() #2244

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 7, 2023

Description

This pull request is to fix #2241 quickly without having to wait for upstream.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

in app.get_subsets()
@pllim pllim added bug Something isn't working trivial Only needs one approval instead of two 💤 backport-v3.5.x on-merge: backport to v3.5.x labels Jun 7, 2023
@pllim pllim added this to the 3.5.1 milestone Jun 7, 2023
@pllim
Copy link
Contributor Author

pllim commented Jun 7, 2023

Ugh... RTD failure is unrelated. Might be my fault still. I'll have to investigate separately.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (62948ba) 91.64% compared to head (f530f52) 91.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2244      +/-   ##
==========================================
- Coverage   91.64%   91.63%   -0.02%     
==========================================
  Files         148      148              
  Lines       16538    16538              
==========================================
- Hits        15157    15154       -3     
- Misses       1381     1384       +3     
Impacted Files Coverage Δ
jdaviz/app.py 93.15% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes my issue, thanks! Not sure what you want to do about that doc failure

@pllim
Copy link
Contributor Author

pllim commented Jun 7, 2023

Doc failure is already fixed upstream.

@pllim pllim enabled auto-merge June 7, 2023 19:10
@pllim pllim merged commit c421b5e into spacetelescope:main Jun 7, 2023
@lumberbot-app

This comment was marked as resolved.

@pllim pllim deleted the ellipse-quick-fix branch June 7, 2023 19:16
pllim added a commit to pllim/jdaviz that referenced this pull request Jun 7, 2023
BUG: Fix ellipse translation in app.get_subsets()
(cherry picked from commit c421b5e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing trivial Only needs one approval instead of two 💤 backport-v3.5.x on-merge: backport to v3.5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Ellipse translation in app.get_subsets() is wrong
2 participants