-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix ellipse translation in app.get_subsets() #2244
Conversation
in app.get_subsets()
Ugh... RTD failure is unrelated. Might be my fault still. I'll have to investigate separately. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2244 +/- ##
==========================================
- Coverage 91.64% 91.63% -0.02%
==========================================
Files 148 148
Lines 16538 16538
==========================================
- Hits 15157 15154 -3
- Misses 1381 1384 +3
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes my issue, thanks! Not sure what you want to do about that doc failure
Doc failure is already fixed upstream. |
This comment was marked as resolved.
This comment was marked as resolved.
BUG: Fix ellipse translation in app.get_subsets() (cherry picked from commit c421b5e)
Description
This pull request is to fix #2241 quickly without having to wait for upstream.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.