refactor!: proof_of_sql_parser::intermediate_ast::BinaryOp with sqlparser::ast::BinaryOp in the proof-of-sql crate

[varshith257]

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

• The PR title and commit messages adhere to guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md. In particular ! is used if and only if at least one breaking change has been introduced.
• I have run the ci check script with source scripts/run_ci_checks.sh.

Rationale for this change

This PR addresses the need to replace the proof_of_sql_parser::intermediate_ast::BinaryOp with the sqlparser::ast::BinaryOp in the proof-of-sql crate as part of a larger transition toward integrating the sqlparser .

This change is a subtask of issue #235, with the main goal of streamlining the repository by switching to the sqlparser crate and gradually replacing intermediary constructs like proof_of_sql_parser::intermediate_ast with sqlparser::ast.

What changes are included in this PR?

• All instances of proof_of_sql_parser::intermediate_ast::BinaryOp have been replaced with sqlparser::ast::BinaryOp
• Every usage of BianryOp has been updated to maintain the original functionality, ensuring no changes to the logic or behavior.
• Any unsupported BinaryOp variants from sqlparser have been appropriately handled using existing error handling mechanisms (i.e., the Unsupported variant in ExpressionEvaluationError).

Are these changes tested?

Yes

Closes #349
Part of #235

[varshith257]

@JayWhite2357 Can I add ignore clippy to this?
https://github.com/spaceandtimelabs/sxt-proof-of-sql/actions/runs/11756005825/job/32751686248#step:6:155

If we go with clippy the signature of impl -> BinaryOP in sqlparser.rs need to get changed?

Which approach could be the best here?

[iajoiner]

@varshith257 If you think clippy is being really absurd you can add ignores.

[iajoiner]

Please rebase with main

[iajoiner]

Looks great! Can we pass in references to not trigger clippy::needless_pass_by_value?

[varshith257]

@iajoiner This is the conflict #362 (comment)

[iajoiner]

@varshith257 OK. Actually in this case I think it is better to comply. Normally it shouldn't hurt to add a few &. If not please let me know.

[iajoiner]

Really thanks! This is awesome!
P.S. I don't really think we need to make changes in this PR to satisfy clippy::needless_pass_by_value since we pass in UnaryOp by value as well and clippy doesn't flag that.

[JayWhite2357]

Looks good. Only request is the clippy lint.

[JayWhite2357]

@JayWhite2357 Can I add ignore clippy to this? https://github.com/spaceandtimelabs/sxt-proof-of-sql/actions/runs/11756005825/job/32751686248#step:6:155

If we go with clippy the signature of impl -> BinaryOP in sqlparser.rs need to get changed?

Which approach could be the best here?

You shouldn't need to change sqlparser.rs. You should just need to add a few &s where clippy asks, and then add a few more at the locations calling those functions. This lint it generally quite simply to resolve unless the method is being called a lot, which I don't think it is here.

[iajoiner]

Thanks for the fixes!

[github-actions]

🎉 This PR is included in version 0.47.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀