Clean up uses of obsolete/EC TransformComponent properties/methods #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts uses of TransformComponent.LocalMatrix to use SharedTransformSystem.GetLocalMatrix
Converts uses of TransformComponent.InvLocalMatrix to use SharedTransformSystem.GetInvLocalMatrix
Changes all uses of TransformComponent.LocalRotation.set to use SharedTransformSystem.SetLocalRotationNoLerp instead
Changes all uses of TransformComponent.WorldMatrix to use SharedTransformSystem.GetWorldMatrix instead
Changes all uses of TransformComponent.WorldPosition to use SharedTransformSystem.GetWorldPosition instead
Changes all uses of TransformComponent.LocalPosition.set to use SharedTransformSystem.SetLocalPositionNoLerp instead
Changes all uses of TransformComponent.AttachParent to use SharedTransformSystem.SetParent instead
Changes all uses of TransformComponent.GetWorldPositionRotation to use SharedTransformSystem.GetWorldPositionRotation instead
Changes all uses of TransformComponent.GetWorldPositionRotationInvMatrix to use SharedTransformSystem.GetWorldPositionRotationInvMatrix instead
Changes all uses of TransformComponent.MapPosition to use SharedTransformSystem.GetMapCoordinates instead
Changes all uses of TransformComponent.WorldRotation to use SharedTransformSystem.GetWorldRotation instead
Changes all uses of TransformComponent.Anchored to use SharedTransformSystem.AnchorEntity or SharedTransformSystem.Unanchor instead
TemporalOroboros
requested review from
metalgearsloth,
PJB3005 and
DrSmugleaf
as code owners
2 tasks
Moves the logic for the LocalMatrix and InvLocalMatrix getters to their system methods. Also obsoletes LocalMatrix and InvLocalMatrix
Moves the logic for the LocalRotation setter to SetLocalRotationNoLerp. Also obsoletes the setter
Moves the logic for the LocalPosition setter to SetLocalPositionNoLerp. Also obsoletes the setter
Moves the logic for the LocalPosition setter to SetLocalPositionNoLerp. Also obsoletes the setter
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should clear out the last of the references to stuff like the
Anchoredsetter or the variousWorldThinggetters.Also adds a basic
SharedTransformSystemAPI forLocalMatrix,InvLocalMatrixandNoLocalRotation.