Ensure parents are always initialized & started before children #5595
+731
−223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to how the client applies game states to ensure that parent entities are always initialized & started before their children are.
Previously, the client would:
Now the client will:
The motivation for this change is to fix a bug that can happen if an existing (already initialized) entity gets attached to a newly created (uninitialized) entity. This PR is an alternative to #5588, and also includes a test to check for the bug that it was trying to fix.
One potential issue is that now entities that depend on other entities during their start-up might run into issues due to other entities not necessarily having had their state updated yet, but AFAICT it doesn't cause any issues and all tests seem to pass? And given that component states already need to assume that the states of other entities haven't been applied yet, it seems reasonable to extend that rule to component init & startup logic.