Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tileref optimisation #5498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor tileref optimisation #5498

wants to merge 1 commit into from

Conversation

metalgearsloth
Copy link
Contributor

Avoids creating it on every enumeration.

PJB3005
PJB3005 reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not obvious to me this is faster, this is a struct type so it's not like there's an allocation happening here, and I actually expect the JIT to be able to inline this properly anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJB3005 PJB3005 PJB3005 left review comments

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metalgearsloth @PJB3005