Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix close propagation on close-delimited responses with front keep-alive #1077

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix close propagation on close-delimited responses with front keep-alive #1077

merged 1 commit into from
Feb 20, 2024

Conversation

Wonshtrum
Copy link
Member

No description provided.

Keksoj
Keksoj suggested changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@Keksoj Keksoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one nitpick about style. I like the change, otherwise.

lib/src/protocol/kawa_h1/mod.rs Show resolved Hide resolved
@Wonshtrum Wonshtrum force-pushed the devel/edemolis/fix/close-delimited branch from 3ce7182 to 59c0615 Compare February 20, 2024 10:42
@FlorentinDUBOIS FlorentinDUBOIS merged commit 129c0d7 into main Feb 20, 2024
21 checks passed
@FlorentinDUBOIS FlorentinDUBOIS deleted the devel/edemolis/fix/close-delimited branch February 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentinDUBOIS FlorentinDUBOIS FlorentinDUBOIS approved these changes

@Keksoj Keksoj Awaiting requested review from Keksoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wonshtrum @FlorentinDUBOIS @Keksoj