Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SNI and peer address on handshake error logs #1041

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add SNI and peer address on handshake error logs #1041

merged 1 commit into from
Nov 28, 2023

Conversation

Wonshtrum
Copy link
Member

@Wonshtrum Wonshtrum commented Nov 28, 2023 •
edited
Loading

Add context on this type of log:

2023-11-28T13:58:27.046295Z 1701179907046295084 158578 WRK-10 ERROR     could not perform handshake: General("no server certificate chain resolved")
2023-11-28T13:58:27.165872Z 1701179907165872745 158553 WRK-02 ERROR     could not perform handshake: PeerIncompatible(NoCipherSuitesInCommon)

like this:

2023-11-28T13:58:27.046295Z 1701179907046295084 158578 WRK-10 ERROR     Session(sni=None, source=40.30.20.1) could not perform handshake: General("no server certificate chain resolved")
2023-11-28T13:58:27.165872Z 1701179907165872745 158553 WRK-02 ERROR     Session(sni=Some(example.com), source=50.40.30.2) could not perform handshake: PeerIncompatible(NoCipherSuitesInCommon)

@FlorentinDUBOIS FlorentinDUBOIS merged commit 9bcdf5b into main Nov 28, 2023
12 checks passed
@FlorentinDUBOIS FlorentinDUBOIS deleted the devel/edemolis/feat/verbose-handshake-error branch November 28, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentinDUBOIS FlorentinDUBOIS FlorentinDUBOIS approved these changes

@Keksoj Keksoj Awaiting requested review from Keksoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wonshtrum @FlorentinDUBOIS