Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel: add option to set aclfile #488

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

simonasr
Copy link
Contributor

@simonasr simonasr commented Jan 3, 2024

Description

Adding aclfile option to Sentinel configuration file.

Issues Resolved

Enables configuring external ACL file for Redis Sentinel v6+

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@simonasr simonasr requested a review from a team as a code owner January 3, 2024 14:35
@damacus damacus merged commit 33dae07 into sous-chefs:main Jan 3, 2024
38 checks passed
@damacus
Copy link
Member

damacus commented Jan 3, 2024

For the short experience I've got with sentinel this should work. So I"m happy to merge as is 🥳

Thanks very much @simonasr

@simonasr simonasr deleted the sentinel_aclfile branch January 4, 2024 11:09
@simonasr
Copy link
Contributor Author

simonasr commented Jan 4, 2024

Thanks @damacus for a such fast response :)
When the new release could be expected?

@damacus
Copy link
Member

damacus commented Jan 4, 2024

I forgot to put a tag on it, so it wont get released 🤦🏼

I'll need to do a small update to release this by itself! Leave that with me 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants