Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove support for EOL Redis versions #486

Merged
merged 12 commits into from
Apr 3, 2024
Merged

cleanup: remove support for EOL Redis versions #486

merged 12 commits into from
Apr 3, 2024

Conversation

simonasr
Copy link
Contributor

@simonasr simonasr commented Nov 20, 2023 •
edited by xorima
Loading

Description

This PR updates Redis configuration to be compatible with version post to v6, following th end-of-life for older versions.
Redis EOL: https://endoflife.date/redis
Related discussion: #485 (comment)

Issues Resolved

  • Remove obsolete Redis version checks
  • Remove deprecated Redis configuration options
  • Update Redis docs in configuration template
  • Update slave -> replica where applicable
  • Remove redis-package test suite
  • Bump Redis version used for tests
  • Update CHANGELOG

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@xorima xorima added the Release: Major Release to Chef Supermarket as a major change when merged label Nov 20, 2023
@xorima
Copy link
Contributor

xorima commented Nov 20, 2023

Adding major as release version as we are removing stuff and version numbers are free.

@simonasr
Copy link
Contributor Author

simonasr commented Jan 3, 2024

Hi @damacus, i'm a bit stuck here:

  • most Linux distributions provide Redis v4 package only, which does not work with "modern" Redis configurations. How could we proceed here - should we remove "redis-package" test suite from integration tests? 🤔

@damacus
Copy link
Member

damacus commented Jan 3, 2024

Yeah just remove the package test here

According to https://endoflife.date/redis we should only be testing 6.3, 7.0 and 7.2. Anything else isn't getting patched

@damacus
Copy link
Member

damacus commented Jan 3, 2024

Not for this cleanup PR, but it's easier to split out the documentation for each of the resources into their own file a la, java/apache2.

@simonasr simonasr force-pushed the cleanup/support_redis6_and_above branch 2 times, most recently from 52bbffe to 5644b2b Compare January 8, 2024 09:06
@simonasr simonasr force-pushed the cleanup/support_redis6_and_above branch 2 times, most recently from cc8f682 to 164dd4b Compare February 8, 2024 14:17
@simonasr simonasr force-pushed the cleanup/support_redis6_and_above branch from 164dd4b to 7392669 Compare February 21, 2024 06:46
@simonasr simonasr marked this pull request as ready for review February 21, 2024 10:48
@simonasr simonasr requested a review from a team as a code owner February 21, 2024 10:48
@simonasr
Copy link
Contributor Author

Hi @damacus
I've finalised the PR and believe it's now ready for review. Finding time to dedicate to this was more challenging than I initially thought. Could you please review it and share your feedback? Additionally, if further modifications or steps are needed, please guide me on how to proceed.

xorima
xorima reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@xorima xorima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker but do we need an upgrading guideline for this?
I.e you have today you need tomorrow kinda things

@simonasr
Copy link
Contributor Author

Not a blocker but do we need an upgrading guideline for this? I.e you have today you need tomorrow kinda things

Thanks @xorima, do you have in mind something like example bellow? 🤔 should this go to the CHANGELOG?

Upgrade Guidelines:

  • Ensure all Redis instances are upgraded to version 6.2.14 or higher.
  • Update configuration files to reflect the terminology change from "slave" to "replica."
  • Remove any references to deprecated options like list-max-ziplist-entries and list-max-ziplist-value.
  • Test the compatibility of your Chef cookbook with Redis v6+ before deploying the upgrade.

@xorima
Copy link
Contributor

xorima commented Apr 1, 2024

I'm happy, but would like further review from @damacus or @ramereth ideally

sorry for missing your message @simonasr , the last few weeks have been full on.

damacus
damacus reviewed Apr 3, 2024
View reviewed changes
README.md
@@ -340,16 +340,16 @@ Available options and their defaults
'rdbcompression' => 'yes',
'rdbchecksum' => 'yes',
'dbfilename' => nil,
'slaveof' => nil,
'replicaof' => nil,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thanks for sorting this outdated language out!

damacus
damacus approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@damacus damacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@damacus damacus merged commit 63bf361 into sous-chefs:main Apr 3, 2024
81 checks passed
@simonasr simonasr deleted the cleanup/support_redis6_and_above branch April 4, 2024 13:29
@kitchen-porter
Copy link
Contributor

Released as: 7.0.0

@xorima
Copy link
Contributor

xorima commented Apr 4, 2024

Shipped, sorry about that, our release system had a bad day ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damacus damacus damacus approved these changes

@xorima xorima xorima approved these changes

Assignees
No one assigned
Labels
Release: Major Release to Chef Supermarket as a major change when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonasr @xorima @damacus @kitchen-porter