Fix gear action in Find with Sourcegraph dialog

[mkondratek]

There was an issue with the action...

Based on PR #7368

Chain of upstream PRs as of 2025-03-07

• PR Merge sourcegraph.cody.Icons and sourcegraph.Icons - merge classes - remove redundant files #7368:
  main ← mkondratek/chore/cleanup-icons

  • PR Fix gear action in Find with Sourcegraph dialog #7369 (THIS ONE):
    mkondratek/chore/cleanup-icons ← mkondratek/fix/gear-action

Test plan

1. right click in the editor
2. Sourcegraph / Find with Sourcegraph...
3. click the gear icon

Before:
nothing

After this PR:
setttings file opens

[dominiccooney]

Do we really need this AnAction, can't we set up the DataContext for the button itself, and the ActionEvent will pick up that context when it is created for the button?

[dominiccooney]

This is deprecated in tip, so don't use it.

If we have to use it, put a TODO: Migrate to X after min version passes Y

[mkondratek]

oh, thanks. my intellij does not show that tip but you are right [Sourcegraph link]. I switched to withDataContext that is not deprecated.

[mkondratek]

Do we really need this AnAction, can't we set up the DataContext for the button itself, and the ActionEvent will pick up that context when it is created for the button?

I was thinking about it and tried it but couldn't get it working. It seems to me that it would require more extensive refactor to make it both clean and working. I wanted to keep this fix as simple as possible.

edit:
Tried once again with something like this:

    ActionButton goToPluginSettingsButton =
        GoToPluginSettingsButtonFactory.createGoToPluginSettingsButton();
    DataContext dataContext = DataManager.getInstance().getDataContext(goToPluginSettingsButton);
    DataManager.getInstance()
        .saveInDataContext(dataContext, Key.create(CommonDataKeys.PROJECT.getName()), project);

But I cannot retrieve the project in the action. It's not included in the action event's data (as it's assigned to the component). I tried to get the component there but I could not find a way to do so and it started to look much more messy 😕

I think my present solution is simple, quick, working and it is already implemented so I'd rather keep it for now. We could rethink and refactor that some day, e.g. when we decide to move all sourcegraph related code to kotlin.