Fix token-receiver url generation logic #7338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
VSC uses two types of login redirect, either by
vscode://sourcegraph.cody-ai
uri if browser and os supports that, or through local http server if it does not.Url we use to trigger redirect looks like that:
https://sourcegraph.com/users/pkukielka-zvxqk/settings/tokens/new/callback?requestFrom=CODY&tokenReceiverUrl=http%3A%2F%2F127.0.0.1%3A58543%aaaabbbbccccddddeeeeffffgggghhhhhh.auth/openidconnect/login?prompt_auth=github&pc=sams&redirect=/user/settings/tokens/new/callback?requestFrom=CODY&tokenReceiverUrl=http%3A%2F%2F127.0.0.1%3A58543%aaaabbbbccccddddeeeeffffgggghhhhhh
But should be:
https://sourcegraph.com/.auth/openidconnect/login?prompt_auth=github&pc=sams&redirect=%2Fuser%2Fsettings%2Ftokens%2Fnew%2Fcallback%3FrequestFrom%3DCODY%26tokenReceiverUrl%3Dhttp%3A%2F%2F127.0.0.1%3A63992%aaaabbbbccccddddeeeeffffgggghhhhhh
It was broken long time ago but we never noticed: #4664
Test plan
Authorize Cody - VS Code Extension?
window will show make sure it opens in newest Chrome (if that is not the case you can simply copy-paste it to Chrome window)Authorize