feat(smart-apply): Adds custom model prompt for smart apply. #7328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitesh-1997
commented
Mar 5, 2025
| @@ -15,27 +11,3 @@ export interface ModelParametersInput { | |||
| export interface ModelParameterProvider { | |||
| getModelParameters(args: ModelParametersInput): CompletionParameters | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Moved this to vscode/src/edit/adapters/default.ts
hitesh-1997
changed the title
hitesh-1997
changed the title
hitesh-1997
changed the title
umpox
approved these changes
Mar 5, 2025
| ${getGuidelinesPrompt()}` | ||
| } | ||
|
|
||
| function getUserPrompt( |
There was a problem hiding this comment.
It would be useful to add some simple snapshot tests for this file, just to view the raw prompt output and check that it looks correct and isn't broken by someone forgetting to add a </ in future
There was a problem hiding this comment.
Good point, let me add this in the follow up PR.
Currently the backend PR is not merged, we should be able to test this when the SG get deloyed tomorrow |
hitesh-1997
force-pushed
the
hitesh/smart-apply-qwen-model
branch
from
e68c366 to
8f33ffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan