refactor(chat): Remove parenthesis wrapping of other files when calling selectedCodePromptWithExtraFiles
#7022
+49
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vovakulikov I'm going to need some help with the tests that fail because the polly recordings will need to be updated. |
This aligns the output of these commands with the output we get from the default prompts.
dominiccooney
force-pushed
the
ichimdav/commands_like_prompts
branch
from
7de6d67 to
7401a14
Compare
dominiccooney
requested changes
Feb 12, 2025
dominiccooney
requested changes
Feb 27, 2025
…uested in review - Now they also show up in the prompt, no longer being added as context without showing up as duplicate context chip - Simplified `selectedCodePromptWithExtraFiles` return as instructed by @dominiccooney
|
@dominiccooney I've addressed your suggestions in a48d316 I really hope that as @kalanchan is prioritizing the changelog generator, a similar effort can be put into giving someone like myself a script or a bot command that I can run to update without needing extra permissions or software in order to avoid having to ask another dev todo this for me. |
- Per instructions in ticket feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(chat): Remove file mention duplication for default commands.
Based on the comments:
#6910 (review)
#6910 (comment)
I'm opening this pull request in order to get rid of the extra setup parentheses between the primary mention and the other mentions.
For extra context on reason see this comment #6910 (comment)
I am also removing the duplication of context mention from the default commands because these commands have been duplicated as default prompts and they do not duplicate the context mention leaving just the context mention with the file range.
Test plan