refactor(sandbox): refactor oauth exmple sandbox #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyagi-Sunny
changed the title
Tyagi-Sunny
changed the title
Tyagi-Sunny
force-pushed
the
oauth-example
branch
from
4794efa to
ee05d32
Compare
yeshamavani
reviewed
Jan 23, 2025
packages/cli/README.md
Outdated
There was a problem hiding this comment.
Revert this file
will unnecessarily release package
There was a problem hiding this comment.
Revert this file
will unnecessarily release package
services/payment-service/openapi.md
Outdated
There was a problem hiding this comment.
Revert this file
will unnecessarily release package
same for all the extra files
sandbox/oauth-example/.env.example
Outdated
Comment on lines
23
to
87
| # GOOGLE_TOKEN_INFO_URL= | ||
| # SAML_URL= | ||
| # SAML_CLIENT_ID= | ||
| # SAML_CLIENT_SECRET= | ||
| # SAML_TOKEN_URL= | ||
| # SAML_CALLBACK_URL= | ||
| # INSTAGRAM_AUTH_URL= | ||
| # INSTAGRAM_AUTH_CLIENT_ID= | ||
| # INSTAGRAM_AUTH_CLIENT_SECRET= | ||
| # INSTAGRAM_AUTH_TOKEN_URL= | ||
| # INSTAGRAM_AUTH_CALLBACK_URL= | ||
| # APPLE_AUTH_URL= | ||
| # APPLE_AUTH_CLIENT_ID= | ||
| # APPLE_AUTH_TEAM_ID= | ||
| # APPLE_AUTH_KEY_ID= | ||
| # APPLE_AUTH_CALLBACK_URL= | ||
| # FACEBOOK_AUTH_URL= | ||
| # FACEBOOK_AUTH_CLIENT_ID= | ||
| # FACEBOOK_AUTH_CLIENT_SECRET= | ||
| # FACEBOOK_AUTH_TOKEN_URL= | ||
| # FACEBOOK_AUTH_CALLBACK_URL= | ||
| # FORGOT_PASSWORD_LINK_EXPIRY= | ||
| # KEYCLOAK_HOST= | ||
| # KEYCLOAK_REALM= | ||
| # KEYCLOAK_CLIENT_ID= | ||
| # KEYCLOAK_CLIENT_SECRET= | ||
| # KEYCLOAK_CALLBACK_URL= | ||
|
|
||
| # # AZURE AD | ||
| # #boolean values will be 0 or 1 | ||
|
|
||
| # AZURE_AUTH_ENABLED= | ||
| # AZURE_IDENTITY_METADATA= | ||
| # AZURE_AUTH_CLIENT_ID= | ||
| # AZURE_AUTH_REDIRECT_URL= | ||
| # AZURE_AUTH_CLIENT_SECRET= | ||
| # AZURE_AUTH_ALLOW_HTTP_REDIRECT= | ||
| # AZURE_AUTH_COOKIE_INSTEAD_SESSION= | ||
| # AZURE_AUTH_PASS_REQ_CALLBACK= | ||
| # AZURE_AUTH_VALIDATE_ISSUER= | ||
| # AZURE_AUTH_B2C_TENANT= | ||
| # AZURE_AUTH_CLOCK_SKEW= | ||
| # AZURE_AUTH_LOG_LEVEL= | ||
| # AZURE_AUTH_LOG_PII= | ||
| # AZURE_AUTH_NONCE_TIME= | ||
| # AZURE_AUTH_NONCE_COUNT= | ||
| # AZURE_AUTH_ISSUER= | ||
|
|
||
| # # key is 32 bit | ||
|
|
||
| # AZURE_AUTH_COOKIE_KEY= | ||
|
|
||
| # #iv is 12 bit | ||
|
|
||
| # AZURE_AUTH_COOKIE_IV= | ||
|
|
||
|
|
||
| # AUTH0_DOMAIN= | ||
| # AUTH0_CLIENT_ID= | ||
| # AUTH0_CLIENT_SECRET= | ||
| # AUTH0_CALLBACK_URL= | ||
|
|
||
| # MAX_JWT_KEYS= | ||
| # JWT_PRIVATE_KEY_PASSPHRASE= | ||
| # API_BASE_URL= |
There was a problem hiding this comment.
why all of these commented
add only the necessary ones
There was a problem hiding this comment.
added only the necessary ones
sandbox/oauth-example/Dockerfile
Outdated
| # The `--chown=node` flag ensures that the ownership of the copied files/directories is set to the `node` user. | ||
| # This is important because the subsequent commands in the Dockerfile are executed with the `node` user, | ||
| # and it needs the appropriate permissions to access and modify the copied files/directories. | ||
| COPY --chown=node packages ./packages |
There was a problem hiding this comment.
why do we need packages here
There was a problem hiding this comment.
this auto generated docker file
There was a problem hiding this comment.
add a seed file for this
for auth_client, tenant, roles etc that needs to be created for this beforehand
There was a problem hiding this comment.
why an empty file
delete it
Comment on lines
17
to
21
| // import { | ||
| // RoleRepository, | ||
| // TenantRepository, | ||
| // UserRepository, | ||
| // } from '../repositories'; |
There was a problem hiding this comment.
hmm, we can import them from auth service
Tyagi-Sunny
force-pushed
the
oauth-example
branch
from
0d20428 to
0e6e9ee
Compare
refactor oauth example MIGRATION CHANGE: migration-20230323132703- refactor oauth example migration-20230524115047- refactor oauth example migration-20240116123737- refactor oauth example migration-20241105074844- refactor oauth example migration-20210421113146- refactor oauth example migration-20220607063927- refactor oauth example migration-20221110095658- refactor oauth example migration-20221123082900- refactor oauth example gh-0
remove sonar MIGRATION CHANGE: migration-20241105074844- remove sonar BREAKING CHANGE: remove sonar remove sonar
resolve test cases gh-0
Tyagi-Sunny
force-pushed
the
oauth-example
branch
from
400c38d to
1c611d0
Compare
update test helper file gh-0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix oauth exmple sandbox
MIGRATION CHANGE:
migration-20230323132703- fix oauth exmple sandbox migration-20240116123737- fix oauth exmple sandbox migration-20241105074844- fix oauth exmple sandbox migration-20210421113146- fix oauth exmple sandbox migration-20220607063927- fix oauth exmple sandbox migration-20221110095658- fix oauth exmple sandbox migration-20221123082900- fix oauth exmple sandbox migration-20230524115047- fix oauth exmple sandbox
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: