-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr-test #9
base: master
Are you sure you want to change the base?
pr-test #9
Conversation
); | ||
|
||
if (true) { | ||
} else if (false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage of ELSE IF is discouraged; use ELSEIF instead
49c3e92
to
d7d7b81
Compare
Lint errors was found. A patch is also available. Please see the report: https://flintci.io/repositories/286/analyses/6 |
@@ -11,7 +11,7 @@ | |||
|
|||
var Admin = { | |||
|
|||
collectionCounters: [], | |||
lolCounters: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- eslint: Unquoted property 'lolCounters' found.
@@ -321,7 +321,7 @@ var Admin = { | |||
counter = parseInt(matches[1], 10); | |||
} | |||
}); | |||
Admin.collectionCounters[collection.attr('id')] = counter; | |||
Admin.lolCounters[collection.attr('id')] = counter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- eslint: Strings must use doublequote.
@@ -331,7 +331,7 @@ var Admin = { | |||
Admin.stopEvent(event); | |||
|
|||
var container = jQuery(this).closest('[data-prototype]'); | |||
var counter = ++Admin.collectionCounters[container.attr('id')]; | |||
var counter = ++Admin.lolCounters[container.attr('id')]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- eslint: Unexpected var, use let or const instead.
- eslint: Combine this with the previous 'var' statement.
- eslint: All 'var' declarations must be at the top of the function scope.
- eslint: Unary operator '++' used.
- eslint: Strings must use doublequote.
@@ -1 +1 @@ | |||
test: 'toto' | |||
test: @toto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- yamllint: syntax error: found character '@' that cannot start any token
@@ -1 +1 @@ | |||
test: 'toto' | |||
test: @toto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- yamllint: syntax error: found character '@' that cannot start any token
@@ -1,2 +1,4 @@ | |||
const test = "toto"; | |||
console.log(test); | |||
|
|||
const toto = "kikou"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- eslint: Combine this with the previous 'const' statement.
- eslint: 'toto' is assigned a value but never used.
@@ -0,0 +1 @@ | |||
test: @toto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- yamllint: syntax error: found character '@' that cannot start any token
691066b
to
56a711b
Compare
Lint errors was found. A patch is also available. Please see the report: http://localhost:9000/app_dev.php/repositories/285/analyses/6 |
d45fc3d
to
b1565e8
Compare
Lint errors was found. A patch is also available. Please see the report: http://localhost:9000/app_dev.php/repositories/285/analyses/7 |
b1565e8
to
cfa6f26
Compare
Lint errors was found. A patch is also available. Please see the report: http://localhost:9000/app_dev.php/repositories/285/analyses/10 |
cfa6f26
to
39ddada
Compare
Lint errors was found. A patch is also available. Please see the report: http://localhost:9000/app_dev.php/repositories/285/analyses/12 |
2204d37
to
2598fce
Compare
Admin.js
Outdated
|
||
/* | ||
* https://github.com/sonata-project/SonataAdminBundle/issues/151 | ||
*if it is a standard browser use preventDefault otherwise it is IE then return false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- eslint: Line 264 exceeds the maximum line length of 80.
Admin.js
Outdated
} | ||
|
||
//if it is a standard browser get target otherwise it is IE then adapt syntax and get target | ||
if (typeof event.target != 'undefined') { | ||
// If it is a standard browser get target otherwise it is IE then adapt syntax and get target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- eslint: Line 276 exceeds the maximum line length of 80.
Admin.js
Outdated
//if it is a standard browser get target otherwise it is IE then adapt syntax and get target | ||
if (typeof event.target != 'undefined') { | ||
// If it is a standard browser get target otherwise it is IE then adapt syntax and get target | ||
if (typeof event.target !== "undefined") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- eslint: Unexpected negated condition.
c05965b
to
ae23843
Compare
Lint errors was found. A patch is also available. Please see the report: http://localhost:8000/repositories/286/analyses/799 |
Lint errors was found. A patch is also available. Please see the report: http://localhost:8000/repositories/286/analyses/801 |
68b4ad9
to
4085989
Compare
Lint errors was found. A patch is also available. This comment was posted by FlintCI. It can be disabled in the repository settings. |
Lint errors was found. A patch is also available. This comment was posted by FlintCI. It can be disabled in the repository settings. |
Lint errors was found. A patch is also available. Please see the report: http://localhost:8000/repositories/286/analyses/809 This comment was posted by FlintCI. It can be disabled in the repository settings. |
Lint errors was found. A patch is also available. This comment was posted by FlintCI. It can be disabled in the repository settings. |
Lint errors was found. A patch is also available. This comment was posted by FlintCI. It can be disabled in the repository settings. |
Lint errors was found. A patch is also available. This comment was posted by FlintCI. It can be disabled in the repository settings. |
Lint errors was found.A patch is also available. Please see the report: http://localhost:8000/repositories/286/analyses/817 This comment was posted by FlintCI. It can be disabled in the repository settings. |
test |
Lint errors was found.A patch is also available. Please see the report: http://localhost:8000/repositories/286/analyses/819 This comment was posted by FlintCI. It can be disabled in the repository settings. |
Lint errors was found.A patch is also available. Please see the report: http://localhost:8000/repositories/286/analyses/821 This comment was posted by FlintCI. It can be disabled in the repository settings. |
No description provided.