Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-test #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pr-test #9

wants to merge 1 commit into from

Conversation

soullivaneuh
Copy link
Owner

No description provided.

);

if (true) {
} else if (false) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage of ELSE IF is discouraged; use ELSEIF instead

@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.

Please see the report: https://flintci.io/repositories/286/analyses/6

@@ -11,7 +11,7 @@

var Admin = {

collectionCounters: [],
lolCounters: [],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Unquoted property 'lolCounters' found.

@@ -321,7 +321,7 @@ var Admin = {
counter = parseInt(matches[1], 10);
}
});
Admin.collectionCounters[collection.attr('id')] = counter;
Admin.lolCounters[collection.attr('id')] = counter;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Strings must use doublequote.

@@ -331,7 +331,7 @@ var Admin = {
Admin.stopEvent(event);

var container = jQuery(this).closest('[data-prototype]');
var counter = ++Admin.collectionCounters[container.attr('id')];
var counter = ++Admin.lolCounters[container.attr('id')];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Unexpected var, use let or const instead.
  • eslint: Combine this with the previous 'var' statement.
  • eslint: All 'var' declarations must be at the top of the function scope.
  • eslint: Unary operator '++' used.
  • eslint: Strings must use doublequote.

@@ -1 +1 @@
test: 'toto'
test: @toto

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • yamllint: syntax error: found character '@' that cannot start any token

@@ -1 +1 @@
test: 'toto'
test: @toto

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • yamllint: syntax error: found character '@' that cannot start any token

@@ -1,2 +1,4 @@
const test = "toto";
console.log(test);

const toto = "kikou";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Combine this with the previous 'const' statement.
  • eslint: 'toto' is assigned a value but never used.

@@ -0,0 +1 @@
test: @toto

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • yamllint: syntax error: found character '@' that cannot start any token

@soullivaneuh soullivaneuh force-pushed the pr-test branch 3 times, most recently from 691066b to 56a711b Compare December 22, 2017 11:20
@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.

Please see the report: http://localhost:9000/app_dev.php/repositories/285/analyses/6

@soullivaneuh soullivaneuh force-pushed the pr-test branch 2 times, most recently from d45fc3d to b1565e8 Compare December 22, 2017 11:25
@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.

Please see the report: http://localhost:9000/app_dev.php/repositories/285/analyses/7

@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.

Please see the report: http://localhost:9000/app_dev.php/repositories/285/analyses/10

@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.

Please see the report: http://localhost:9000/app_dev.php/repositories/285/analyses/12

@soullivaneuh soullivaneuh force-pushed the pr-test branch 9 times, most recently from 2204d37 to 2598fce Compare December 22, 2017 14:53
Admin.js Outdated

/*
* https://github.com/sonata-project/SonataAdminBundle/issues/151
*if it is a standard browser use preventDefault otherwise it is IE then return false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Line 264 exceeds the maximum line length of 80.

Admin.js Outdated
}

//if it is a standard browser get target otherwise it is IE then adapt syntax and get target
if (typeof event.target != 'undefined') {
// If it is a standard browser get target otherwise it is IE then adapt syntax and get target

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Line 276 exceeds the maximum line length of 80.

Admin.js Outdated
//if it is a standard browser get target otherwise it is IE then adapt syntax and get target
if (typeof event.target != 'undefined') {
// If it is a standard browser get target otherwise it is IE then adapt syntax and get target
if (typeof event.target !== "undefined") {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • eslint: Unexpected negated condition.

@soullivaneuh soullivaneuh force-pushed the pr-test branch 2 times, most recently from c05965b to ae23843 Compare January 13, 2018 15:08
@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.

Please see the report: http://localhost:8000/repositories/286/analyses/799

@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.

Please see the report: http://localhost:8000/repositories/286/analyses/801

@soullivaneuh soullivaneuh force-pushed the pr-test branch 2 times, most recently from 68b4ad9 to 4085989 Compare January 14, 2018 13:41
@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.
Please see the report: http://localhost:8000/repositories/286/analyses/805

This comment was posted by FlintCI. It can be disabled in the repository settings.

@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.
Please see the report: http://localhost:8000/repositories/286/analyses/807

This comment was posted by FlintCI. It can be disabled in the repository settings.

@FlintCIBot
Copy link

FlintCIBot commented Jan 14, 2018

Lint errors was found.

A patch is also available.

Please see the report: http://localhost:8000/repositories/286/analyses/809

This comment was posted by FlintCI. It can be disabled in the repository settings.

@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.
Please see the report: http://localhost:8000/repositories/286/analyses/811

This comment was posted by FlintCI. It can be disabled in the repository settings.

@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.
Please see the report: http://localhost:8000/repositories/286/analyses/813

This comment was posted by FlintCI. It can be disabled in the repository settings.

@FlintCIBot
Copy link

Lint errors was found.

A patch is also available.
Please see the report: http://localhost:8000/repositories/286/analyses/815

This comment was posted by FlintCI. It can be disabled in the repository settings.

@FlintCIBot
Copy link

FlintCIBot commented Jan 14, 2018

Lint errors was found.A patch is also available.

Please see the report: http://localhost:8000/repositories/286/analyses/817

This comment was posted by FlintCI. It can be disabled in the repository settings.

@soullivaneuh
Copy link
Owner Author

test

@FlintCIBot
Copy link

Lint errors was found.A patch is also available.

Please see the report: http://localhost:8000/repositories/286/analyses/819

This comment was posted by FlintCI. It can be disabled in the repository settings.

@FlintCIBot
Copy link

Lint errors was found.A patch is also available.

Please see the report: http://localhost:8000/repositories/286/analyses/821

This comment was posted by FlintCI. It can be disabled in the repository settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants