Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gpg module condition #1682

Closed
wants to merge 5 commits into from
Closed

Fix gpg module condition #1682

wants to merge 5 commits into from

Conversation

Vonfry
Copy link

@Vonfry Vonfry commented Jan 26, 2019

Fixes #1681

Proposed Changes

  • gpg module: if-condition ( grep expression and find socket file) in modules/gpg/init.zsh between line 16 to 25.

Vonfry and others added 5 commits January 26, 2019 11:00
@Vonfry
Fix gpg module condition
d66a099 
Fix gpg module grep regex expression, because of matching failed when `GPG_AGENT_INFO` is empty. 

And use gpgconf to get socket file instead of `$GNUPGHOME`.

fix: sorin-ionescu#1681
gpg-module: unset socket variable
5ebe88b
gpg module: grep conditon fix
a170d5b
gpg modules: use gpgconf for other variable
2e1b45c
remove export after ln, because some tools will check the socket path
7d32a08 
such as pam ssh auth on NixOS.
@Vonfry
Copy link
Author

Vonfry commented Jan 26, 2019 •
edited
Loading

Add more: remove re-export SSH_AUTH_SOCK in ssh module. Becasue some tools such as pam ssh auth will check socket file permission. A link to this socket is useful but re-export the variable will break some tools.

@ghost
Copy link

ghost commented Jun 22, 2019

This pull request seems to fix #1164 for me.

@Vonfry
Copy link
Author

Vonfry commented Aug 7, 2019

close pr for fixing this in another branch not master

@Vonfry Vonfry closed this Aug 7, 2019
@Vonfry Vonfry mentioned this pull request Aug 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPG module output agent already running on NixOS
1 participant
@Vonfry