-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake & latest node #13
base: master
Are you sure you want to change the base?
Conversation
…and attempt to use prebuild
The fork tjpeg seemed unstable when tested. But might be that the api has changed? |
I found a couple of segfaults in the node bindings, which could be the instability you found? |
Could you do some testing with windows on node 9? If I don’t remeber totatally wrong, companion segfaulted when I tried to upgrade to tjpeg. |
sure, I can do that. |
@haakonnessjoen There are some unit tests in this now, and I have also done some manual tests for node 9 on windows, and it is working fine. I intend to use this library myself with my StreamDeck XL, both through companion and my own stuff, so I will happily look into segfaults or bugs if any are found. |
@sorccu #8 (comment) |
@Julusian OpenSTF maintainer here. Thanks for your work, sorry for no response for a long time and FYI this repository is not planned to be maintained as well as OpenSTF. |
This builds off the work of another fork (https://github.com/briskycat/node-tjpeg)
EDIT: This fork is published as @julusian/jpeg-turbo and will be updated until this PR is merged.
Changes:
I have published a build of this as
@julusian/jpeg-turbo
v0.5.1, so feel free to use that package to do any testing. That is also populated with a set of prebuilds https://github.com/Julusian/node-jpeg-turbo/releases/tag/v0.5.1, so should be quick and easy to use.CI is testing that this builds in each of node 8, 10 and 12 (except windows which is using 11 instead of 12).
I have tested it myself on Windows 10 (node 10), macos (node 8) and ubuntu (node 8)