Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Mobile ver. - ErrorPage 구현 #388

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

eonseok-jeon
Copy link
Member

@eonseok-jeon eonseok-jeon commented Aug 13, 2024

Related Issue : Closes #378


🧑‍🎤 Summary

  • error page 반응형 구현
  • no more page 반응형 구현
  • 헤더 자리 padding 80px으로 변경됨에 따른 error page 컨텐츠 높이 다시 계산

🧑‍🎤 Screenshot

스크린샷 2024-08-13 오후 3 48 02
스크린샷 2024-08-13 오후 3 48 53

🧑‍🎤 Comment

단순 작업이라 크게 어려움은 없었어요

header를 sticky에서 fixed로 변경하면서 padding을 80 추가 해준 덕분에
에러 페이지에서 헤더가 있는지 없는지에 따라 조건부로 height을 계산할 필요가 없어졌어요
헤더 있든 없든 padding 80은 항상 존재하니까요
다만 기존에는 74로 설정이 되어있었기에 이를 다 80으로 수정했어요

no more page는 제가 만든 페이지라 디자인이 없어요 😅
해당 페이지 만들 때 error page를 참고하여 만든 거기 때문에 에러 페이지와 동일하게 적용해줬어요

@eonseok-jeon eonseok-jeon linked an issue Aug 13, 2024 that may be closed by this pull request
Copy link

height bot commented Aug 13, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모두 확인했습니다 :)

그 선화가 작업하면서 저희 breakPoint가 살짝 달라져서 useDevice 훅에 수정이 생길텐데,
우선 에러페이지는 디자인 보니 breakPoint 바뀌어도 문제 없을 것 같아요!

수고하셨습니다~~

@eonseok-jeon
Copy link
Member Author

@lydiacho
문제 생기면 그때 또 수정할게여~

@eonseok-jeon eonseok-jeon merged commit 1997730 into develop Aug 13, 2024
1 check passed
@eonseok-jeon eonseok-jeon deleted the design/#378_mobile-error-page branch August 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] Mobile ver. - ErrorPage 구현
2 participants