Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Coffee Chat QA 사항 반영 #532

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[Fix] Coffee Chat QA 사항 반영 #532

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5471b62
fix: coffeeChatTopic validation 200->1000자로 변경
jun02160 Nov 5, 2024
5d18652
chore: 문자 발송 시 '[]' 문자 제거
jun02160 Nov 5, 2024
1acea81
chore: 코드리뷰 반영
jun02160 Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/org/sopt/makers/internal/external/gabia/SmsChatSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import org.sopt.makers.internal.member.service.MemberRetriever;
import org.springframework.stereotype.Service;

import java.util.stream.Collectors;

@Service
@RequiredArgsConstructor
public class SmsChatSender implements MessageSender {
Expand All @@ -20,7 +22,7 @@ public void sendMessage(Member sender, Member receiver, String content, String r
"연결을 원하신다면 멤버의 전화번호로 직접 연락해 주세요.\n\n" +
"- 이름: " + sender.getName() + "\n" +
"- 연락처: " + replyInfo + "\n" +
"- 파트: " + memberRetriever.concatPartAndGeneration(sender.getId()) + "\n" +
"- 파트: " + String.join(", ", memberRetriever.concatPartAndGeneration(sender.getId())) + "\n" +
"- 멤버 프로필 링크: https://playground.sopt.org/members/" + sender.getId() + "\n\n" +
"- 이런 내용이 궁금해요\n" +
content;
Expand Down
2 changes: 1 addition & 1 deletion ...pt/makers/internal/member/controller/coffeechat/dto/request/CoffeeChatDetailsRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public record CoffeeChatInfo(

@Schema(required = true)
@NotBlank(message = "커피챗 주제는 필수 입력 값입니다.")
@Size(max = 200, message = "커피챗 주제는 200자를 초과할 수 없습니다.")
@Size(max = 1000, message = "커피챗 주제는 1000자를 초과할 수 없습니다.")
String topic,

@Schema(required = true)
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/sopt/makers/internal/member/service/MemberRetriever.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import org.springframework.stereotype.Component;

import java.util.List;
import java.util.stream.Collectors;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 해당 Import가 추가된 이유가 있을까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 테스트 중에 추가된 것 같네요
1acea81 에서 반영했습니다!


@Component
@RequiredArgsConstructor
Expand Down
Loading