Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T-10855 [feat] GET /authorize API 구현 #260
T-10855 [feat] GET /authorize API 구현 #260
Changes from 16 commits
81c0a33
db6fa35
6900681
37019ad
fed5aba
2a17ed4
8b183a2
69d84e8
f6f722c
a12ef89
87f5f62
bb61d07
4fc2a2b
c826462
1fae6f0
ebf4996
98b4cd6
2491109
7b2f524
9f5a36e
8405fc1
6bf98a0
fa4f889
7a42391
2dcc511
e28e609
5b69e2d
a06028b
6830ab0
4838ec1
f9e3268
39f5a2b
f04ec56
3ccaaad
e5a3acb
deea533
a3c1e2f
6402942
801b7ce
2a066de
37a0408
a7c381b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P4
별 건 아니구
class
와 내부 내용 사이에 개행!!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P4
개행하면 조금 더 가독성 좋을 것 같습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 엔티티는 db를 통해 insert하기 때문에 save 등을 사용하지 않아 entity를 생성할 일이 없기 때문에 만들지 않았습니다
getter 또한 jpa query문을 통해 충분히 검증할 수 있기 때문에 만들지 않았습니다
위 builder 및 getter 모두 추후 필요한 상황이 생긴다면 만들 것 같습니다.