Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 테스트 중 500 에러 수정 + 추가 리팩토링 #245

Merged
merged 16 commits into from
Feb 28, 2024

Conversation

dragontaek-lee
Copy link
Member

@dragontaek-lee dragontaek-lee commented Feb 18, 2024

Related Issue 🚀

Work Description ✏️

  • 테스트를 하며 생긴 500 이슈를 해결하였습니다.
  • 리팩토링 도중 없어졌던 로직을 추가하였습니다.
  • 리팩토링을 추가로 진행하였습니다.

PR Point 📸

  • 논의할만한 부분 코멘트로 남겨놨습니다.

@dragontaek-lee dragontaek-lee added bug Something isn't working chore 잡일 yongtaek 용택 작업 fix 작업 수정 labels Feb 18, 2024
@dragontaek-lee dragontaek-lee self-assigned this Feb 18, 2024
Copy link
Collaborator

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
개인적인 생각 리뷰로 추가했어요 :)
필요하다면 참고해주시면 감사하겠습니다!

@dragontaek-lee dragontaek-lee added this pull request to the merge queue Feb 28, 2024
Merged via the queue into develop with commit 3a1f85f Feb 28, 2024
1 check passed
@thguss thguss deleted the yongtaek_#238 branch March 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore 잡일 fix 작업 수정 size/L yongtaek 용택 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 앱 모듈 리팩토링
2 participants