[REFACTOR] 2차 기능 리팩토링 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thguss
approved these changes
Feb 15, 2024
...c/main/java/org/sopt/makers/operation/app/attendance/dto/response/LectureAttendResponse.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/sopt/makers/operation/app/attendance/dto/response/LectureAttendResponse.java
Outdated
Show resolved
Hide resolved
| val subLecture = subAttendance.getSubLecture(); | ||
| val isOnAttendanceCheck = LocalDateTime.now().isBefore(subLecture.getStartAt().plusMinutes(10)); | ||
| val message = getMessage(lecture.getAttribute()); | ||
| if (isOnAttendanceCheck && subAttendance.getStatus().equals(ABSENT)) { |
There was a problem hiding this comment.
if문 안의 코드를 별도 메소드로 묶어내면 가독성이 더 좋아질 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🚀
Work Description ✏️
PR Point 📸